Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarification about when instance_vars can be called #11171

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

willhbr
Copy link
Contributor

@willhbr willhbr commented Sep 5, 2021

I believe this is in line with this forum post. This would have saved me some confused debugging as to why I kept getting an empty list!

@Blacksmoke16
Copy link
Member

Related: #10662

@Sija
Copy link
Contributor

Sija commented Sep 5, 2021

A code example would help to convey the meaning.

Copy link
Member

@oprypin oprypin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regardless of higher-level pending items, the direct improvement is great

@straight-shoota straight-shoota added this to the 1.2.0 milestone Sep 6, 2021
@straight-shoota straight-shoota merged commit 479a314 into crystal-lang:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants