Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BigRational#to_big_r #11462

Merged
merged 1 commit into from Nov 18, 2021
Merged

Add BigRational#to_big_r #11462

merged 1 commit into from Nov 18, 2021

Conversation

HertzDevil
Copy link
Contributor

#to_big_r is defined in Int, Float, BigInt, and BigDecimal, but oddly not BigRational itself; since BigRational inherits from Number directly, it does not define #to_big_r. This PR adds it back.

@straight-shoota straight-shoota added this to the 1.3.0 milestone Nov 17, 2021
@straight-shoota straight-shoota merged commit a9ee264 into crystal-lang:master Nov 18, 2021
@HertzDevil HertzDevil deleted the feature/bigrational-to_big_r branch November 29, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oprypin oprypin oprypin approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib:numeric
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HertzDevil @oprypin @straight-shoota