Compiler: bind to tuple, not array #12423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very tiny optimization that probably has no effect on perceived memory or time: we are creating an intermediate array every time there's an
ifin the code. In the compiler's source code that happens around 100K times. So with this change we are allocating 100K less arrays.Starting from today I'll be sending small and medium PRs to try to optimize the compiler's performance. They won't be as drastic as something like incremental or modular compilation, but I believe these can still help reduce the overall memory and time used.
I also won't overflow this repo with these small PRs: I'll wait for one to be merged before sending the next one.