Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename File.real_path to .realpath #12552

Conversation

straight-shoota
Copy link
Member

Resolves #12544

Renaming the internal methods and variables isn't strictly necessary, but it makes a lot of sense to stay consistent.

@asterite
Copy link
Member

asterite commented Oct 3, 2022

So a no-op? 😄

@Fryguy
Copy link
Contributor

Fryguy commented Oct 3, 2022

Sorry to be pedantic, but I think you meant Rename File.real_path to .realpath

@straight-shoota straight-shoota changed the title Rename File.real_path to .real_path Rename File.real_path to .realpath Oct 3, 2022
@straight-shoota straight-shoota added this to the 1.7.0 milestone Oct 3, 2022
@straight-shoota straight-shoota merged commit 1124706 into crystal-lang:master Oct 23, 2022
@straight-shoota straight-shoota deleted the feature/rename-file.realpath branch October 23, 2022 16:28
lbguilherme pushed a commit to lbguilherme/crystal that referenced this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename File.real_path to .realpath
3 participants