Enable arc4random(3) on all supported BSDs and macOS/Darwin
#12608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All BSD-based platforms supported by Crystal have arc4random(3), add support for it where it was missing. Fixes #12607
straight-shoota
approved these changes
Oct 13, 2022
straight-shoota
added
topic:stdlib:crypto
platform:bsd
kind:feature
and removed
topic:stdlib:numeric
platform:freebsd
kind:bug
labels
|
Haha sorry, @Blacksmoke16 I completely swapped all your labels 😆 Just for clarification: I'd see it as feature, not a bug because Random worked on all BSDs, this just enables using a better function (I guess missing that could be seen as a bug, but it's not hard broken). Also we've usually labeled issues about |
|
Haha all good, I was basing it off of the original issue. Updated that one to be feature and generic bsd as well. |
Add arc4random support to macOS/Darwin
dmgk
changed the title
jgaskins
reviewed
Oct 22, 2022
Co-authored-by: Jamie Gaskins <jgaskins@hey.com>
straight-shoota
approved these changes
Oct 22, 2022
sdogruyol
approved these changes
Nov 15, 2022
straight-shoota
changed the title
arc4random(3) on all supported BSDs and macOS/Darwin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All BSD-based platforms supported by Crystal have arc4random(3), add support for it where it was missing.
Fixes #12607