Refactor libXML error handling to remove global state #12663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libXML error handlers are now set right before calling a lib function collecting errors directly in that context. Afterwards the error handler is reset. There is no longer a global array collecting errors at `XML::Error.errors`.
Sija
reviewed
Oct 25, 2022
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
This was referenced Oct 26, 2022
Closed
beta-ziliani
approved these changes
Nov 15, 2022
Co-authored-by: Beta Ziliani <beta@manas.tech>
|
Hi, just letting you know this is a breaking change since the |
|
Good point! The detail to return |
straight-shoota
added a commit
to straight-shoota/crystal
that referenced
this pull request
Nov 28, 2022
This restores the original semantics prior to the refactoring of crystal-lang#12663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libXML error handlers are now set right before calling a lib function collecting errors directly in that context. Afterwards the error handler is reset. There is no longer a global array collecting errors at
XML::Error.errors.The idea was sparked by @asterite in #12659 (comment), with explanation in #12659 (comment)
Resolves #12649
Closes #12652
Closes #12659