Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate nil from many predicate methods #12702

Merged
merged 1 commit into from
Nov 6, 2022
Merged

Eliminate nil from many predicate methods #12702

merged 1 commit into from
Nov 6, 2022

Conversation

HertzDevil
Copy link
Contributor

A lot of predicate methods are returning Bool | Nil when just Bool would suffice, most notably Crystal::Type#implements?. This PR removes those nils.

@straight-shoota straight-shoota mentioned this pull request Oct 31, 2022
Open
@straight-shoota straight-shoota added this to the 1.7.0 milestone Nov 4, 2022
@straight-shoota straight-shoota merged commit 1308ca9 into crystal-lang:master Nov 6, 2022
@HertzDevil HertzDevil deleted the perf/predicate-nilable-bool branch November 18, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

@caspiano caspiano caspiano approved these changes

Assignees
No one assigned
Labels
kind:refactor performance topic:compiler topic:stdlib
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HertzDevil @straight-shoota @caspiano