Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Indexable#rindex! method variant #12759

Merged

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Nov 18, 2022

Followup to #12730 adding the bang variant to the collection types as well (via Indexable).

@Sija Sija force-pushed the add-enumerable-rindex-bang-variant branch from 0aac153 to 264ef65 Compare November 18, 2022 22:34
@Sija
Copy link
Contributor Author

Sija commented Nov 26, 2022

Since #12730 landed, this might too, I guess? (:

src/indexable.cr Outdated Show resolved Hide resolved
src/indexable.cr Outdated Show resolved Hide resolved
@Sija Sija requested a review from HertzDevil December 13, 2022 14:53
@straight-shoota straight-shoota added this to the 1.7.0 milestone Dec 15, 2022
@straight-shoota straight-shoota merged commit 174bb00 into crystal-lang:master Dec 15, 2022
carlhoerberg pushed a commit to carlhoerberg/crystal that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants