Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new SI prefixes in Number#humanize #12761

Merged

Conversation

HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil commented Nov 19, 2022

Adds support for ronna- (1027), quetta- (1030), ronto- (10-27), and quecto- (10-30), which were officially added at the 27th meeting of the CGPM.

#humanize_bytes implicitly supports R, Ri, Q, and Qi. Technically they are from a different standard but there is little reason to believe the new prefixes would deviate from the SI ones.

Also fixes #12760.

@straight-shoota straight-shoota added this to the 1.7.0 milestone Nov 19, 2022
@straight-shoota straight-shoota merged commit 66379f5 into crystal-lang:master Nov 21, 2022
@HertzDevil HertzDevil deleted the feature/new-si-prefixes branch November 26, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number#humanize fails for values outside the SI prefix range
2 participants