Fix: Read UInt in zip directory header
#12822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Dec 5, 2022
HertzDevil
approved these changes
Dec 13, 2022
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
straight-shoota
approved these changes
Dec 16, 2022
straight-shoota
changed the title
UInt in zip directory header
carlhoerberg
pushed a commit
to carlhoerberg/crystal
that referenced
this pull request
Dec 21, 2022
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the writer is working correctly but can't read files with more than 32767 files due to a mismatch of int16 and uint16