Add error handling to compiler when linker is unavailable #12899
Conversation
src/compiler/crystal/compiler.cr
Outdated
| Process.run(command, args, shell: true, | ||
| input: Process::Redirect::Close, output: Process::Redirect::Inherit, error: Process::Redirect::Pipe) do |process| | ||
| process.error.each_line(chomp: false) do |line| | ||
| next if line.matches?(/^--: 1: .*: not found$/) |
There was a problem hiding this comment.
Should we avoid skipping lines if --verbose is used?
There was a problem hiding this comment.
Sounds good. This is definitely one of the more fuzzy aspects. I suppose it should also only skip the first line, not if it appears later in the output.
There was a problem hiding this comment.
I don't follow why only the first line. I would avoid filtering entirely on --verbose.
There was a problem hiding this comment.
First line would be independent of verbose.
| next if line.matches?(/^--: 1: .*: not found$/) | |
| next if first_line && !verbose && line.matches?(/^--: 1: .*: not found$/) |
There was a problem hiding this comment.
The filter is supposed to remove the "command not found" string? The zsh: command not found: xxxx? Or is it something else?
There was a problem hiding this comment.
Yeah, that's the idea. But I feel like maybe it's better to remove that. At least for now. It's a convenience feature, but not really necessary. And it's not super accurate in any case.
| else | ||
| link_flags = @link_flags || "" | ||
| link_flags += " -rdynamic" | ||
|
|
||
| { %(#{CC} "${@}" -o #{Process.quote_posix(output_filename)} #{link_flags} #{program.lib_flags}), object_names } | ||
| {CC, %(#{CC} "${@}" -o #{Process.quote_posix(output_filename)} #{link_flags} #{program.lib_flags}), object_names} |
There was a problem hiding this comment.
The actual executable could be different from CC if the environment variable is something like FOO=BAR gcc. But I don't have a good solution for that because parse_arguments is not sufficient for arbitrary shell commands
There was a problem hiding this comment.
Yeah, I think that's good enough. And definitely an improvement over printing the full linker command line which can easily span multiple pages.
I suppose if we had a good solution for that, we also wouldn't need to run Process.run(shell: true) through /bin/sh 🤷 🤣
straight-shoota
force-pushed
the
feature/compiler-linker-not_found
branch
from
0157e60
to
b4366be
Compare
|
Rebased on top of https://github.com/crystal-lang/crystal/tree/release/1.7 for merging into 1.7.2. That required a force push. |
Fixes #12839
The first two commits are simply refactoring to drop the
process_wrapperhelper method which is unnecessary and only complicates control flow.The third commit introduces a short name in
linker_commandwhich refers to the command itself without the additional autogenerated arguments (which can be quite a lot).Alternatively, we could also use
parse_argumentsto extract the name from the final command. But the original value is already available anyway, and it's easy to just forward it.The fourth commit then implements the actual error handling. Due to #12873 it covers errors indicated by exceptions as well as exit status.