Add OAuth2::Client#make_token_request returning HTTP response
#12921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And make it flexible to add additional request headers
|
Thanks for this patch. I think we should talk about the reasoning behind this and potentially evaluate alternative API solutions. |
…p response object
cyangle
changed the title
straight-shoota
approved these changes
Feb 3, 2023
src/oauth2/client.cr
Outdated
| } | ||
|
|
||
| # Makes a token exchange request with custom headers and form fields | ||
| # Returns a HTTP::Client::Response |
There was a problem hiding this comment.
This is superfluous. The return type is sufficiently indicated in the method signature.
Suggested change
| # Returns a HTTP::Client::Response |
…ent_get_access_token
…le/crystal into expose_OAuth2_Client_get_access_token
straight-shoota
approved these changes
Feb 4, 2023
straight-shoota
changed the title
OAuth2::Client#make_token_request returning HTTP response
sdogruyol
approved these changes
Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make OAuth2::Client#get_access_token a public method
So that one can pass custom headers and form params