Fix wrong default address when binding sockets

[etra0]

Hello! This is my first PR!

The following code would crash on my laptop:

require "socket"

entry = TCPSocket.new
entry.bind(1234)

With the stacktrace

Unhandled exception: Hostname lookup for :: failed: No address found (Socket::Addrinfo::Error)
  from /opt/homebrew/Cellar/crystal/1.7.2/share/crystal/src/socket/addrinfo.cr:132:7 in 'bind'
  from /opt/homebrew/Cellar/crystal/1.7.2/share/crystal/src/socket/ip_socket.cr:23:5 in 'bind'
  from smth.cr:4:1 in '__crystal_main'

Because it tries to resolve the address :: when the Family is INET.

I am unsure on raising an exception because that case should never hit since you cannot initiate an unix socket by only assigning a port, advice is welcomed!

[straight-shoota]

Thanks for your contribution! Looks good 👍

About the error case: Currently you'll get an exception with message Failed to create socket: Protocol not supported when calling this method with a non-inet family:

entry = TCPSocket.new(family: :unix)
entry.bind(1234) # SocketError: Failed to create socket: Protocol not supported

I think that's what should happen after this patch as well. Now we could handle this case explicitly here, or just pass it through. An exception will be raise eventually.
So maybe the address could just be @family.inet? ? "0.0.0.0:#{port}" : "::#{port}", effectively just changing the current behaviour for INET family.

Note that directly interpolating the address and port is an optimization that avoids an intermediary string allocation.

[etra0]

hey, thanks for the feedback!

FWIW I just tested the example you sent and it still raises the exception you mention, because that one is triggered in the .new method I think.

changes updated 😄

[straight-shoota]

Please avoid force pushes to active PRs. Instead, just append changes as new commits. See https://github.com/crystal-lang/crystal/blob/master/CONTRIBUTING.md#making-good-pull-requests
Thanks.

[etra0]

Oh, I'm sorry for overwriting the history, should have caught that earlier when reading the contributing docs.

[straight-shoota]

Looks all good 👍

[Sija]

LGTM 🚀

[etra0]

I don't think the failures are related to this PR. One is from OAuth, and the other one to bind SSL server but from the stacktrace it doesn't seem to touch any of my changes.