Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for slow specs #13043

Conversation

straight-shoota
Copy link
Member

Resolves #12860

@straight-shoota straight-shoota force-pushed the fix/increase-timeout-for-slow-spec branch from 3c5ae04 to d0d30ca Compare February 2, 2023 18:56
Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. In the future it'd be better to append the whole timeout machinery only to problematic tests.

@beta-ziliani beta-ziliani added this to the 1.8.0 milestone Feb 8, 2023
@straight-shoota straight-shoota merged commit 39cac0e into crystal-lang:master Feb 9, 2023
@straight-shoota straight-shoota deleted the fix/increase-timeout-for-slow-spec branch February 9, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Occasional timeout in preview_mt specs
2 participants