New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign documents #1305
Redesign documents #1305
Conversation
How can i fix it? |
Don't worry, it's not you. The 32bit build just does that sometimes for some reason :/ |
This is awesome ❤️ I only have some minor remarks:
Maybe for a later iteration I think it would be awesome to have methods too in the search results and I think I wouldn't even mind them in the tree, similar to how devdocs.io does it. |
Maybe keep the blue links (but a nicer one than #00F) and have a light-gray background (#EEE) for the sidebar? That would better fit most projects by default. Thought the purple scheme was very nice overall. |
Great stuff! There is so much thought put into everything. Some issues, though:
Nitpicks/suggestions:
|
@rosylilly I love this new design!! ❤️❤️❤️❤️❤️❤️ I'll merge this right away. I think it's a million years ahead of what the current docs look and behave like. We can always tweek and enhance the small details later. And I like the purple color too 😊 @BlaXpirit it was me who added that top "permalink", because it was hard to get it with all those frames. But now we can remove it. A "source" link is hard because a type might spawn multiple files... but there's the "defined in" section which lists them, and you can click them. |
Thank you for review. ref: This design's color palette: http://paletton.com/palette.php?uid=64v0N0kmOkocquJhYphs3fazG9T |
Both of these are fixed easily and surprisingly well by changing the classes from Currently opened modules will be expanded AND when exiting from it it will be collapsed back unless you used arrow to expand it. Check it out here: http://blaxpirit.github.io/crsfml/api/SF/Shader.html |
@rosylilly I thought something was different: the code snippets have a different style! They look much clean and professional now. Thank you again! |
New design of documents.
It's includes some fixes:
<frame>
You can preview this PR. Let's access https://crystal-doc-new-design.herokuapp.com/ .