Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use @[ThreadLocal] for PCRE2's JIT stack #13056

Conversation

HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil commented Feb 9, 2023

Fixes #13013.

Verified on an M2 and on Windows.

Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@straight-shoota straight-shoota added this to the 1.8.0 milestone Feb 9, 2023
@straight-shoota straight-shoota merged commit 1aa099d into crystal-lang:master Feb 10, 2023
@HertzDevil HertzDevil deleted the refactor/pcre2-jit-stack-threadlocal branch February 13, 2023 16:04
@straight-shoota straight-shoota modified the milestones: 1.8.0, 1.7.3 Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PCRE2 JIT compilation causes invalid memory access
3 participants