Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly treat unbound type vars in generic class methods as free variables #13125

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Explicitly treat unbound type vars in generic class methods as free variables #13125

merged 1 commit into from
Mar 2, 2023

Conversation

HertzDevil
Copy link
Contributor

Fixes #13110.

@HertzDevil HertzDevil added kind:bug topic:compiler:generics kind:regression Something that used to correctly work but no longer works labels Feb 28, 2023
@straight-shoota straight-shoota modified the milestones: 1.8.0, 1.7.3 Feb 28, 2023
@straight-shoota straight-shoota changed the base branch from master to release/1.7 March 1, 2023 12:36
@straight-shoota straight-shoota force-pushed the bug/generic-class-method-free-var branch from 849e662 to c8eec1c Compare March 1, 2023 12:38
@straight-shoota straight-shoota merged commit 9eab606 into crystal-lang:release/1.7 Mar 2, 2023
@straight-shoota straight-shoota mentioned this pull request Mar 2, 2023
Closed
@HertzDevil HertzDevil deleted the bug/generic-class-method-free-var branch March 2, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug kind:regression Something that used to correctly work but no longer works topic:compiler:generics
Projects
None yet
Milestone
1.7.3
Development

Successfully merging this pull request may close these issues.

Numerical generics cannot be inferred
2 participants
@HertzDevil @straight-shoota