Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: detect stack overflows on non-main Fibers #13220

Merged
merged 5 commits into from
Mar 25, 2023
Merged

Windows: detect stack overflows on non-main Fibers #13220

merged 5 commits into from
Mar 25, 2023

Conversation

HertzDevil
Copy link
Contributor

Resolves #13192.

straight-shoota
straight-shoota approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The system info should not change during the runtime of a process, and consequently neither the value of total_reserved. So I'm wondering if it makes sense to calculate that only once and put it in a constant?

@straight-shoota straight-shoota added this to the 1.8.0 milestone Mar 24, 2023
@straight-shoota straight-shoota merged commit bd2f527 into crystal-lang:master Mar 25, 2023
@HertzDevil HertzDevil deleted the feature/windows-fiber-stack-overflow branch March 27, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija left review comments

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:feature platform:windows topic:stdlib:runtime
Projects
Windows Support
Status: Done
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Windows cannot detect stack overflows on spawned fibers
3 participants
@HertzDevil @Sija @straight-shoota