-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more members to Regex::Options
#13223
Add more members to Regex::Options
#13223
Conversation
Can't we keep the open option for PCRE? I mean, if |
@beta-ziliani Actually, I'm not sure about that. While we're still supporting automatic fallback to PCRE if PCRE2 is unavailable it seems weird to have different behaviour for the |
can't we simply detect the engine and act upon that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all the issues has been addressed. Unless @Blacksmoke16 or @HertzDevil raise another issue, I consider this ready 🚀
related specs are failing |
This is a first iteration of the enhancement of
Regex::Options
to decouple it from any specific libpcre values and also add more defined flags for advanced use cases as described in #13152 (comment)