Fix: LibC definition for sys/socket.h (*-linux-gnu targets) #13242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I introduced a buggy LibC definition of `sys/socket.h` in December 2023 (see 56dec21) that was only recently noticed (crystal-lang#12982) and identified (crystal-lang#12982 (comment)).
Blacksmoke16
added
kind:bug
topic:stdlib:networking
kind:regression
|
i don't think a 6yo regression should count as such 😆 |
Blacksmoke16
removed
the
kind:regression
Just for the sake of correctness (`int` is the same size as `size_t` on i386).
ysbaddaden
changed the title
ysbaddaden
changed the title
straight-shoota
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a buggy LibC definition of
sys/socket.hin December 2016 (see 56dec21) that was only recently noticed (#12982) and identified (#12982 (comment)).I'm amazed it went undetected for 6 years.
closes #12982