Implement `#match!` for Regex #13285

devnote-dev · 2023-04-05T10:19:20Z

This PR implements String#match! and Regex#match! (the former using the latter) and replaces all the Regex::MatchData examples using #not_nil! with #match!. Closes #13119 and #13120.

straight-shoota · 2023-04-05T10:55:49Z

Looks good 👍
But I think the exception raised when there is no match should be more specific than Exception. Maybe we could keep NilAssertionError from .not_nil!, but that would feel odd. Regex::Error might be a more suitable candidate?

devnote-dev · 2023-04-05T11:08:17Z

I went with Exception because #not_nil! was too ambiguous, ~~I don't think Regex::Error exists though? If not then I can add it in the regex file.~~

Found it, it was at the top 😅

src/regex.cr

spec/std/regex_spec.cr

Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>

src/regex/match_data.cr

src/regex.cr

…into string-match

straight-shoota

Specs for String#match! would be nice.
Besides that I just have some small suggestions for doc improvements.

src/regex.cr

src/string.cr

Co-authored-by: Johannes Müller <straightshoota@gmail.com>

devnote-dev · 2023-04-21T10:12:45Z

Specs for String#match! would be nice.

Is that necessary? String#match! calls Regex#match! so there would be no difference in specs.

straight-shoota · 2023-04-21T11:54:08Z

Yes, that's currently the implementation. And chances are that it's gonna stay that way more or less. But this method isn't just a simple delegation due to the assignment of $~. And there could be some future refactoring with break potential. It's best to have specs to cover at least the basic expected behaviour.

Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl> Co-authored-by: Johannes Müller <straightshoota@gmail.com>

devnote-dev added 5 commits April 5, 2023 10:47

feat(string, regex): implement #match!

df6ed19

chore(spec/std): add Regex#match! specs

e8614e7

fix(spec/std): add exception arguments

9d8e3d7

chore(spec/std): remove deprecated regex match spec

31661d5

feat(regex/match_data): replace not_nil! examples with match!

5048780

straight-shoota added kind:feature topic:stdlib:text labels Apr 5, 2023

chore(regex): use Error over Exception

0a5d200

Sija reviewed Apr 5, 2023

View reviewed changes

src/regex.cr Outdated Show resolved Hide resolved

chore(regex): improve error message

15e018c

Sija reviewed Apr 5, 2023

View reviewed changes

spec/std/regex_spec.cr Outdated Show resolved Hide resolved

spec/std/regex_spec.cr Outdated Show resolved Hide resolved

devnote-dev and others added 2 commits April 5, 2023 13:56

Update spec/std/regex_spec.cr

a796411

Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>

Update spec/std/regex_spec.cr

a823ae0

Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>

HertzDevil reviewed Apr 5, 2023

View reviewed changes

src/regex/match_data.cr Outdated Show resolved Hide resolved

Sija reviewed Apr 5, 2023

View reviewed changes

src/regex.cr Outdated Show resolved Hide resolved

devnote-dev and others added 3 commits April 5, 2023 23:55

chore(regex): formatting

f150c53

Merge branch 'string-match' of https://github.com/devnote-dev/crystal …

bd5da7c

…into string-match

Merge branch 'master' into string-match

6e0a951

straight-shoota reviewed Apr 21, 2023

View reviewed changes

src/regex.cr Outdated Show resolved Hide resolved

src/regex.cr Outdated Show resolved Hide resolved

src/string.cr Outdated Show resolved Hide resolved

devnote-dev and others added 4 commits April 21, 2023 11:06

fix: remove unnecessary typing

d0d7e5e

Co-authored-by: Johannes Müller <straightshoota@gmail.com>

fix: include exception type

5070d5b

Co-authored-by: Johannes Müller <straightshoota@gmail.com>

fix: include exception type

7554209

Co-authored-by: Johannes Müller <straightshoota@gmail.com>

Merge branch 'master' into string-match

79ee5d9

devnote-dev added 2 commits April 21, 2023 19:11

Merge branch 'master' into string-match

40d4b69

chore(spec/std): add String#match! specs

1730fa9

straight-shoota approved these changes Apr 24, 2023

View reviewed changes

oprypin changed the title ~~feat: implement #match! for Regex~~ Implement #match! for Regex May 25, 2023

beta-ziliani approved these changes Jun 3, 2023

View reviewed changes

beta-ziliani added this to the 1.9.0 milestone Jun 3, 2023

straight-shoota merged commit 1b5dcee into crystal-lang:master Jun 6, 2023

devnote-dev deleted the string-match branch June 6, 2023 09:16

stufro mentioned this pull request Jul 23, 2023

Remove not_nil! from Regex::MatchData docs #13120

Closed

Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023

Implement #match! for Regex (crystal-lang#13285)

089d9cc

Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl> Co-authored-by: Johannes Müller <straightshoota@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement `#match!` for Regex #13285

Implement `#match!` for Regex #13285

devnote-dev commented Apr 5, 2023

straight-shoota commented Apr 5, 2023

devnote-dev commented Apr 5, 2023 •

edited

Loading

straight-shoota left a comment

devnote-dev commented Apr 21, 2023

straight-shoota commented Apr 21, 2023 •

edited

Loading

Implement #match! for Regex #13285

Implement #match! for Regex #13285

Conversation

devnote-dev commented Apr 5, 2023

straight-shoota commented Apr 5, 2023

devnote-dev commented Apr 5, 2023 • edited Loading

straight-shoota left a comment

Choose a reason for hiding this comment

devnote-dev commented Apr 21, 2023

straight-shoota commented Apr 21, 2023 • edited Loading

Implement `#match!` for Regex #13285

Implement `#match!` for Regex #13285

devnote-dev commented Apr 5, 2023 •

edited

Loading

straight-shoota commented Apr 21, 2023 •

edited

Loading