Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters for Regex::MatchOptions to matching methods #13353

Conversation

straight-shoota
Copy link
Member

This resolves the bulk of #13323.
It covers methods exposing regex match behaviour in String, StringScanner, CSV and Log::EntriesChecker.

@HertzDevil
Copy link
Contributor

The merge conflicts from #13406 need to be resolved

@beta-ziliani beta-ziliani added this to the 1.9.0 milestone Jun 3, 2023
@straight-shoota straight-shoota removed this from the 1.9.0 milestone Jun 6, 2023
@straight-shoota straight-shoota added this to the 1.9.0 milestone Jun 6, 2023
@straight-shoota straight-shoota merged commit 97e9b3d into crystal-lang:master Jun 14, 2023
46 checks passed
@straight-shoota straight-shoota deleted the feature/regex-matching-methods-options branch June 14, 2023 18:04
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants