Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timeout events getting lost on Windows #13525

Merged
merged 2 commits into from Jun 14, 2023
Merged

Fix timeout events getting lost on Windows #13525

merged 2 commits into from Jun 14, 2023

Conversation

HertzDevil
Copy link
Contributor

Fixes #13519 in a relatively non-intrusive manner. (The more intrusive alternative is to turn Crystal::EventLoop::Event into a module and Crystal::Iocp::Event into a class.)

straight-shoota
straight-shoota requested changes Jun 5, 2023
View reviewed changes
src/deque.cr Outdated Show resolved Hide resolved
@straight-shoota straight-shoota mentioned this pull request Jun 5, 2023
Closed
@straight-shoota straight-shoota added this to the 1.9.0 milestone Jun 6, 2023
@straight-shoota straight-shoota merged commit 9930425 into crystal-lang:master Jun 14, 2023
46 checks passed
@HertzDevil HertzDevil deleted the bug/windows-select-timeout branch June 15, 2023 12:21
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
@HertzDevil @Blacksmoke16
Fix timeout events getting lost on Windows (crystal-lang#13525)
ebe5ea4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug platform:windows topic:stdlib:concurrency
Projects
Windows Support
Status: Done
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Timeout action broken on Windows
2 participants
@HertzDevil @straight-shoota