Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not attempt downcasing first when case-folding a Char #13542

Merged
merged 2 commits into from Jun 6, 2023

Conversation

HertzDevil
Copy link
Contributor

Fixes the case-folding bug mentioned in #13534.

@HertzDevil HertzDevil changed the title Do not attempt downcasing before case-folding Do not attempt downcasing first when case-folding a Char Jun 2, 2023
@beta-ziliani
Copy link
Member

I might be missing something, but doesn't these specs run in current master too? What's observably different?

@HertzDevil
Copy link
Contributor Author

those two (oops)

@beta-ziliani beta-ziliani added this to the 1.9.0 milestone Jun 5, 2023
@straight-shoota straight-shoota merged commit fa8203d into crystal-lang:master Jun 6, 2023
46 checks passed
@HertzDevil HertzDevil deleted the bug/downcase-fold branch June 15, 2023 12:22
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants