Add yield key in Hash#transform_values and value in #transform_keys

[baseballlover723]

Fixes #13581

[straight-shoota]

Food for thought: Maybe a simpler implementation could combine key and value?

Suggested change

	expected_values = h1.values
	h2 = h1.transform_keys do |x, v|
	v.should eq(expected_values.shift)
	x + 1
	end
	h2.should eq({2 => "a", 3 => "b", 4 => "c"})
	h1.transform_keys{ |k, v| "#{k}#{v}" }.should eq({"2a" => "a", "3b" => "b", "4c" => "c"})

The same can be applied to all other tests.

[baseballlover723]

updated.

Note: for transform_key! I had to change the type of the hash from Hash(String, Int32) to Hash(String, String) since you can't change the value type in place so that it could use the key value in that spec.

[beta-ziliani]

Thanks for the contribution @baseballlover723! Let me add to what was said that the types of the blocks are not respecting the change, and it would be great if the docs can reflect the change too with a little comment.

Let us know if you want us to take over, or if you prefer to take it to completion.

[baseballlover723]

@beta-ziliani I'd prefer to take it to completion if possible. To clarify, is what you're asking me to do to update the function defs from def transform_values(& : V -> V2) : Hash(K, V2) forall V2 -> def transform_values(& : V, K -> V2) : Hash(K, V2) forall V2? I was surprised that it worked even without updating the type blocks.

I'll also update the docs as well, though I don't really want to change the example code structure, so the added value will just be unused in the example block.

[beta-ziliani]

yes, exactly, that's what I mean. About the documentation, I just meant to add a line stating that the value/key are also yielded to the block. thanks for taking it!

[baseballlover723]

@beta-ziliani updated the docs, let me know if the wording is ok with you.

[beta-ziliani]

Awesome, thanks @baseballlover723 !