Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Dir.delete to remove read-only directories on Windows #13626

Conversation

HertzDevil
Copy link
Contributor

Like #13462, but for directories.

Note that the read-only toggle on the file properties dialog may not be what you think it is; instead attrib /D should be used to show whether a directory itself has the read-only flag.

@straight-shoota straight-shoota added this to the 1.9.0 milestone Jul 3, 2023
@straight-shoota straight-shoota merged commit 6410314 into crystal-lang:master Jul 5, 2023
49 of 52 checks passed
@HertzDevil HertzDevil deleted the bug/windows-dir-delete-read-only branch July 5, 2023 13:33
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants