Add File#rename
#13640
Merged
Add File#rename
#13640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like File.rename, but updates the `@path` of the instance
HertzDevil
approved these changes
Jul 7, 2023
nobodywasishere
approved these changes
Jul 7, 2023
kuraga
reviewed
Oct 9, 2023
| # Rename the current `File` | ||
| def rename(new_filename : Path | String) : Nil | ||
| File.rename(@path, new_filename) | ||
| @path = new_filename.to_s |
There was a problem hiding this comment.
Do the both cases the same?
new_filename could be just a file name (as the test covers)) but could be a (full) path...
BTW is @path a (stringified) path or a file name?
There was a problem hiding this comment.
@path is whatever you pass to the constructor. It can be a single file name or consist of multiple path components. It makes no difference which.
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like File.rename, but updates the
@pathof the instance