Fix spec for String#encode and String.new on DragonFlyBSD
#13944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeopJr
changed the title
String#encode and String#decode on DragonFlyBSDString#encode and String#new on DragonFlyBSD
GeopJr
force-pushed
the
fix/spec/string-encode-string-decode-dragonflybsd
branch
from
7aee877
to
8e14b82
Compare
GeopJr
changed the title
String#encode and String#new on DragonFlyBSDString#encode and String.new on DragonFlyBSD
GeopJr
force-pushed
the
fix/spec/string-encode-string-decode-dragonflybsd
branch
from
8e14b82
to
479d634
Compare
HertzDevil
approved these changes
Nov 3, 2023
straight-shoota
approved these changes
Nov 3, 2023
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #13942, I noticed some String specs failing on DragonFlyBSD (more details) due to the same iconv encoder expectation as FreeBSD
The smoke tests won't catch them so here's the output:
before
after
