Generate src/html/entities.cr automatically
#13998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Nov 20, 2023
Comment on lines
+21
to
+23
| when 1; single_char_entities | ||
| when 2; double_char_entities | ||
| else raise "Unknown entity codepoint size" |
There was a problem hiding this comment.
Suggested change
| when 1; single_char_entities | |
| when 2; double_char_entities | |
| else raise "Unknown entity codepoint size" | |
| when 1 then single_char_entities | |
| when 2 then double_char_entities | |
| else raise "Unknown entity codepoint size" |
straight-shoota
approved these changes
Nov 20, 2023
|
Aarch64 CI is failing |
|
The CI failure seems unrelated to this PR and is tracked in #14007 |
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes a few duplicate entities in the lookup table that arise from dropping the final
;.