Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize BigInt#&, #|, #^ with Int::Primitive arguments #14006

Merged
merged 1 commit into from Nov 23, 2023
Merged

Optimize BigInt#&, #|, #^ with Int::Primitive arguments #14006

merged 1 commit into from Nov 23, 2023

Conversation

HertzDevil
Copy link
Contributor

After converting the argument to a BigInt, saves one intermediary BigInt allocation by mutating that value directly.

@straight-shoota straight-shoota added this to the 1.11.0 milestone Nov 22, 2023
@straight-shoota straight-shoota merged commit 60c0334 into crystal-lang:master Nov 23, 2023
52 of 55 checks passed
@HertzDevil HertzDevil deleted the perf/bigint-bitwise branch November 24, 2023 07:21
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
@HertzDevil @Blacksmoke16
Optimize BigInt#&, #|, #^ with Int::Primitive arguments (crys…
f465e7a 
…tal-lang#14006)
@BrewTestBot BrewTestBot mentioned this pull request Jan 8, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
performance topic:stdlib:numeric
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HertzDevil @straight-shoota