Implement sprintf "%f" in Crystal using Ryu Printf
#14067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems the large constant tables are breaking WebAssembly CI in a similar fashion to #13918? |
Sija
reviewed
Dec 7, 2023
| @@ -334,6 +346,75 @@ struct String::Formatter(A) | |||
| pad(str_size, flags) if flags.right_padding? | |||
| end | |||
|
|
|||
| {% unless flag?(:wasm32) %} | |||
There was a problem hiding this comment.
This might be redundant due to the LLVM optimizations?
Fryguy
reviewed
Dec 7, 2023
straight-shoota
approved these changes
Dec 12, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12473. Resolves part of #8441.
%e,%g,%a, and their uppercase variants will be implemented in subsequent PRs; this PR sets up the general code structure.Note that it is undefined behavior in C to specify both the
0flag and a precision for float formats, but Ruby supports it, so Crystal follows suit.