Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Never use string interpolation in Crystal::System.print_error #14114

Merged
merged 2 commits into from Dec 20, 2023
Merged

Never use string interpolation in Crystal::System.print_error #14114

merged 2 commits into from Dec 20, 2023

Conversation

HertzDevil
Copy link
Contributor

This prevents very bad things like the following from happening:

$ CRYSTAL_WORKERS=%d crystal run -Dpreview_mt file.cr
FATAL: invalid value for CRYSTAL_WORKERS: 44429088
$ CRYSTAL_WORKERS=%n crystal run -Dpreview_mt file.cr
Program received and didn't handle signal ABRT (6)

@straight-shoota straight-shoota added this to the 1.11.0 milestone Dec 19, 2023
@straight-shoota straight-shoota merged commit 60e8357 into crystal-lang:master Dec 20, 2023
55 checks passed
@HertzDevil HertzDevil deleted the bug/print-error-interpolation branch December 21, 2023 12:14
@BrewTestBot BrewTestBot mentioned this pull request Jan 8, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug topic:stdlib:runtime
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HertzDevil @straight-shoota