Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed logo image into repository and upgrade to SVG #14137

Merged

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Dec 22, 2023

The current image is a low-res PNG, the new SVG brings higher fidelity.
Embedding it into the repository ensures availability without internet access.
The docs generator does not support static assets, so we need to copy the asset explicitly into the docs folder (see #13756).

@Vendicated
Copy link
Contributor

Vendicated commented Dec 23, 2023

it's a bit hard to read and not nice to look at when using dark theme

so it might be a good idea to keep the white background like the old png

or you could make two separate versions, one for dark and one for light, but that likely won't work outside of github's markdown viewer

looks much crisper though!

@straight-shoota
Copy link
Member Author

Good catch 👍
I actually went a different route making the SVG itself aware of the color scheme.

@Vendicated
Copy link
Contributor

that's even better, i forgot you can do that :octocat:

@beta-ziliani beta-ziliani added this to the 1.11.0 milestone Jan 3, 2024
@straight-shoota straight-shoota merged commit 3e05a2a into crystal-lang:master Jan 4, 2024
56 checks passed
@straight-shoota straight-shoota deleted the infra/embed-logo branch January 4, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants