Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @[Link]'s DLL search order in the interpreter on Windows #14146

Conversation

HertzDevil
Copy link
Contributor

Prioritizes DLLs at CRYSTAL_LIBRARY_PATH, the compiler's directory, and PATH, just like #14131 in compiled code. Note that the DLL in the same directory as the import library is no longer considered, since CRYSTAL_LIBRARY_PATH should already be sufficient.

The default DLL search order is still needed for things like system DLLs.

@straight-shoota straight-shoota added this to the 1.12.0 milestone Jan 11, 2024
@straight-shoota straight-shoota merged commit bb96c53 into crystal-lang:master Jan 13, 2024
56 checks passed
@HertzDevil HertzDevil deleted the feature/windows-interpreter-dll-search branch January 31, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants