Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crystal tool flags #14234

Merged
merged 2 commits into from Jan 31, 2024

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Jan 14, 2024

This is a simple tool to print all macro flag? values. It's useful to compare them with the documentation (crystal-lang/crystal-book#734). Nope, they're currently not congruent (crystal-lang/crystal-book#735).

@beta-ziliani
Copy link
Member

If this is specific to us, wouldn't it make sense to have it as a separate tool? (or even a sed script?)

@straight-shoota
Copy link
Member Author

No this is not specific for the compiler/stdlib. It should be generally useful for any Crystal program that uses compile time flags.

@beta-ziliani
Copy link
Member

The thing is that listing the flags without any explanation isn't that useful. There's the documentation for that 🤔

@straight-shoota
Copy link
Member Author

Yeah, the main purpose of the tool is is to support being able to document them. It inform which flags are used so you can make sure they're all documented.

@beta-ziliani
Copy link
Member

Right, then I don't think it belongs in the compiler

@beta-ziliani
Copy link
Member

Scrap that last message and sorry for the confusion. This is good, although, can we have tests?

@beta-ziliani beta-ziliani added this to the 1.12.0 milestone Jan 30, 2024
@straight-shoota straight-shoota merged commit 202c655 into crystal-lang:master Jan 31, 2024
57 checks passed
@straight-shoota straight-shoota deleted the feat/tool-flags branch January 31, 2024 12:20
@crysbot
Copy link

crysbot commented Mar 26, 2024

This pull request has been mentioned on Crystal Forum. There might be relevant details there:

https://forum.crystal-lang.org/t/upcoming-1-12-0-release/6714/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants