Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect NO_COLOR in the compiler #14260

Merged

Conversation

HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil commented Jan 28, 2024

This is not Colorize.on_tty_only!, because in theory @compiler's output and error streams may not be STDOUT and STDERR. (In practice that will work until #13925 is resolved.)

@straight-shoota straight-shoota added this to the 1.12.0 milestone Jan 28, 2024
@straight-shoota straight-shoota merged commit ab96337 into crystal-lang:master Jan 29, 2024
57 checks passed
@HertzDevil HertzDevil deleted the feature/compiler-no_color branch January 30, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants