Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shard.yml #14365

Merged
merged 4 commits into from Mar 19, 2024
Merged

Conversation

straight-shoota
Copy link
Member

Resolves #14363

The version of `reply` didn't match any particular commit on its master
branch, so I figure it might've been from a feature branch.
Anyway, the commit referenced now has no relevant differences to the
previously checked in version, so this is a good approximation.
@HertzDevil
Copy link
Contributor

When I tried this, the symlink directories at lib/markd/lib and lib/reply/lib were included in the commit, so I wonder if something went wrong in my setup

@straight-shoota
Copy link
Member Author

Ah no, I messed up with my git diff. It looked clean when it wasn't. 🤦 The lib symlinks are to be included, of course.

shard.yml Outdated Show resolved Hide resolved
shard.yml Outdated Show resolved Hide resolved
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
@straight-shoota straight-shoota added this to the 1.12.0 milestone Mar 18, 2024
@straight-shoota straight-shoota merged commit c4542a6 into crystal-lang:master Mar 19, 2024
58 checks passed
@straight-shoota straight-shoota deleted the feat/shard.yml branch March 19, 2024 11:44
@crysbot
Copy link

crysbot commented Mar 26, 2024

This pull request has been mentioned on Crystal Forum. There might be relevant details there:

https://forum.crystal-lang.org/t/upcoming-1-12-0-release/6714/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage compiler dependencies with shards
5 participants