Add IO::FileDescriptor::Handle
#14390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
reviewed
Mar 22, 2024
| @volatile_fd : Atomic(Handle) | ||
|
|
||
| # Returns the raw file-descriptor handle. Its type is platform-specific. | ||
| def fd : Handle |
There was a problem hiding this comment.
If Handle becomes LibC::HANDLE, wouldn't this type restriction need to be reverted back to Int?
There was a problem hiding this comment.
Yeah if we want to go that way, we might need to split between the internal and external representation of the handle. Let's take this step by step, though. FileDescriptor:Handle is supposed to be a generic name used for public APIs.
The exact type is platform-specific, but it should be a concrete type, not Int.
We could consider using the same type on all platforms in the future (SizeT probably). But I fear that would be too much of a breaking change for Unix systems right now.
HertzDevil
approved these changes
Mar 23, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a generic type representing a platform-specific file descriptor handle, analog to
Socket::Handle.Resolves part of #14389