Do not strip the macOS target triple #14466
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I only address macOS here, but a discussion is worth having about whether we want to perform any stripping of the target triple in |
Starting with Xcode 15, the minimum deployment target is required in the target triple. See also: * crystal-lang/distribution-scripts#296
hovsater
force-pushed
the
macos-target-triple-stripping
branch
from
11cb100
to
d4db294
Compare
straight-shoota
approved these changes
Apr 12, 2024
|
Could this be merged or is there something blocking it? |
beta-ziliani
reviewed
May 2, 2024
| @@ -91,12 +91,6 @@ module LLVM | |||
| def self.default_target_triple : String | |||
| chars = LibLLVM.get_default_target_triple | |||
| case triple = string_and_dispose(chars) | |||
| when .starts_with?("x86_64-apple-macosx"), .starts_with?("x86_64-apple-darwin") | |||
There was a problem hiding this comment.
Isn't this still needed to remove the deployment version?
There was a problem hiding this comment.
I deliberately remove this because we want to keep the minimum deployment target. Since not specifying it, causes linker warnings as of Xcode 15. See #13846 (comment) for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of Xcode 15, a new linker was introduced and with it came warnings messages as seen in #13846. It appears that the new linker is stricter in which target triples it considers valid. Specifically, it looks like the minimum deployment target is required. E.g.,
aarch64-apple-darwin23.3.0is valid, whileaarch64-apple-darwinis not. See #13846 (comment) for details.This PR is a follow-up of crystal-lang/distribution-scripts#296. While we have corrected the target triple for macOS
arm64builds,x86_64builds would still emit warnings due to us stripping the minimum deployment target inLLVM.default_target_triple.Fixes #13846
Fixes #14052