Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatter with whitespace before closing parenthesis #14471

Merged
merged 1 commit into from Apr 10, 2024
Merged

Fix formatter with whitespace before closing parenthesis #14471

merged 1 commit into from Apr 10, 2024

Conversation

straight-shoota
Copy link
Member

Resolves #14470

@straight-shoota straight-shoota added kind:bug topic:tools:formatter kind:regression Something that used to correctly work but no longer works labels Apr 10, 2024
@straight-shoota straight-shoota self-assigned this Apr 10, 2024
Blacksmoke16
Blacksmoke16 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@Blacksmoke16 Blacksmoke16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this resolves the issue reported via Athena CI.

@straight-shoota straight-shoota added this to the 1.12.1 milestone Apr 10, 2024
@straight-shoota straight-shoota merged commit 85525fc into crystal-lang:master Apr 10, 2024
57 of 58 checks passed
@straight-shoota straight-shoota deleted the fix/formatter-parenthesized-args branch April 10, 2024 19:57
@BrewTestBot BrewTestBot mentioned this pull request Apr 11, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blacksmoke16 Blacksmoke16 Blacksmoke16 approved these changes

Assignees

@straight-shoota straight-shoota

Labels
kind:bug kind:regression Something that used to correctly work but no longer works topic:tools:formatter
Projects
None yet
Milestone
1.12.1
Development

Successfully merging this pull request may close these issues.

Formatter error regression
2 participants
@straight-shoota @Blacksmoke16