Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StringPool#get? #14508

Merged
merged 2 commits into from Apr 23, 2024
Merged

Add StringPool#get? #14508

merged 2 commits into from Apr 23, 2024

Conversation

HertzDevil
Copy link
Contributor

Resolves #11217.

@straight-shoota straight-shoota added this to the 1.13.0 milestone Apr 18, 2024
ysbaddaden
ysbaddaden approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@ysbaddaden ysbaddaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple yet very welcomed addition 👍

src/string_pool.cr Show resolved Hide resolved
src/string_pool.cr Outdated Show resolved Hide resolved
@straight-shoota
Copy link
Member

@HertzDevil WDYT about Julien's suggestions?

@straight-shoota straight-shoota merged commit 1f76cf6 into crystal-lang:master Apr 23, 2024
60 checks passed
@straight-shoota straight-shoota mentioned this pull request Apr 23, 2024
Open
@HertzDevil HertzDevil deleted the feature/string-pool-get-question branch April 24, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysbaddaden ysbaddaden ysbaddaden approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib:text
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Add StringPool#get? variants
3 participants
@HertzDevil @straight-shoota @ysbaddaden