Fix BigRational#format
#14525
Open
Fix BigRational#format
#14525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: I forgot that the big library can't be imported, so the type of the number can't be checked. I implemented an alternative solution, but might that not be that safe? |
|
You could override just this overload in |
Sija
reviewed
Apr 22, 2024
HertzDevil
reviewed
Apr 22, 2024
Sija
reviewed
Apr 23, 2024
src/big/big_rational.cr
Outdated
Comment on lines
365
to
367
| self.denominator.format(io, separator, delimiter, decimal_places, group: group, only_significant: only_significant) | ||
| io << '/' | ||
| self.numerator.format(io, separator, delimiter, decimal_places, group: group, only_significant: only_significant) |
There was a problem hiding this comment.
Suggestion: you can drop self receiver:
Suggested change
| self.denominator.format(io, separator, delimiter, decimal_places, group: group, only_significant: only_significant) | |
| io << '/' | |
| self.numerator.format(io, separator, delimiter, decimal_places, group: group, only_significant: only_significant) | |
| denominator.format(io, separator, delimiter, decimal_places, group: group, only_significant: only_significant) | |
| io << '/' | |
| numerator.format(io, separator, delimiter, decimal_places, group: group, only_significant: only_significant) |
straight-shoota
changed the title
straight-shoota
changed the title
BigRational#format
straight-shoota
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #14062
This is a small change, but it fixes the issue and is perhaps not the most efficient solution; the main goal was to not affect the current code base too much.
In the issues, there are 2 approaches mentioned; I went ahead with this one since if a user wants the result as a float, they can still do that by converting the BigRational to a float.
But I want to present this PR more as a proposal for a solution than as a final solution (thereby, no tests are written/updated). If there is consensus to take the other approach, is that also an option.