Fix blockless IO::FileDescriptor echo and raw mode methods
#14529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysbaddaden
approved these changes
Apr 23, 2024
straight-shoota
approved these changes
Apr 23, 2024
|
Windows CI is failing quite interestingly: https://github.com/crystal-lang/crystal/actions/runs/8792765757/job/24131162983?pr=14529
Yet this seems unrelated to this PR. |
apainintheneck
added a commit
to apainintheneck/anticipate
that referenced
this pull request
Apr 25, 2024
This should be opened with the LibC open command so that it's in tty mode and can be turned into raw tty mode. Unfortunately that is not possible yet because there is a bug in the current Crystal version with turning file descriptors into raw mode without a block. That should be fixed in Crystal 1.13.0. See crystal-lang/crystal#14529
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14528.