Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor use IO#read_byte instead of #read_char in HTTP::ChunkedContent #14548

Merged

Conversation

straight-shoota
Copy link
Member

The HTTP protocol is based on ASCII characters, so there's no need to employ UTF-8 decoding.

ysbaddaden
ysbaddaden approved these changes Apr 30, 2024
@straight-shoota straight-shoota added this to the 1.13.0 milestone Apr 30, 2024
@straight-shoota straight-shoota merged commit 89f2e43 into crystal-lang:master May 1, 2024
60 checks passed
@straight-shoota straight-shoota deleted the refactor/http-read_char branch May 1, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants