Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor base64 encoding #14611

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Refactor base64 encoding #14611

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
752fab7
Allow passing an `IO` as the Base64.encode source
jgaskins May 21, 2024
f9ffa35
Replace explicit Bytes.new with `.to_slice`
jgaskins May 22, 2024
cf4cc03
Rewrite base64 encoding
BlobCodes May 23, 2024
c7b7192
Fix off-by-one error
BlobCodes May 23, 2024
b662f34
Use memcpy instead of memmove
BlobCodes May 23, 2024
50b3c78
Improve variable naming
BlobCodes May 24, 2024
5f9bb9e
Add comment explaining fast full pair encode
BlobCodes May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/base64.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ module Base64
# *input* must have at least `pairs * 3` bytes available to process,
# while *output* must have at least `pairs * 4` bytes of storage available.
private def encode_base64_full_pairs_internal(input : UInt8*, output : UInt8*, pairs : Int32, chars : UInt8*) : Nil
while pairs >= 8
while pairs > 8
BlobCodes marked this conversation as resolved.
Show resolved Hide resolved
i = 8
while i != 0
value = 0_u32
Expand Down
Loading