Rename Crystal::System.print_error(fmt, *args, &) to printf
#14617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method doesn't print anything but merely formats a string using a subset of C printf, hence the renaming as `printf(fmt, *args, &)`. Also adds a `#print_error(bytes)` method to write to the standard error directly, without any formatting, that may be done separately (e.g. into a buffer) then written. Using a buffer is useful to avoid interleaved error messages with MT for example. Keeps `#print_error(fmt, *args)` that now merely uses the other two methods.
straight-shoota
approved these changes
May 23, 2024
straight-shoota
changed the title
Crystal::System.print_error(fmt, *args, &) to printf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method doesn't print anything but merely formats a string using a subset of C printf, hence the renaming as
printf(fmt, *args, &).Also adds a
#print_error(bytes)method to write to the standard error directly, without any formatting, that may be done separately (e.g. into a buffer) then written. Using a buffer is useful to avoid interleaved error messages with MT for example.Keeps
#print_error(fmt, *args)that now merely uses the other two methods.This has been extracted from #14599.