Don't pass socket file descriptors to subprocesses on Unix (SOCK_CLOEXEC)

[carlhoerberg]

The comment 8 lines down suggests that this has been lost at some point.

Fixes #14630

[ysbaddaden]

Searching the history, I think we never had it. Let's fix that!

[straight-shoota]

This seems like the right thing to do. It was probably just missed in the original implementation.

suggestion: Add comments with cross-references between the different implementations in create_handle and initialize_handle.
I'm also wondering if the fcntl part shouldn't be moved to create_handle, but that's a different issue.

[straight-shoota]

suggestion: Add a simple spec to ensure this doesn't get lost somewhere. A simple check for close_on_exec? should do:

it "socket closes on exec by default" do
  socket = Socket.new(Socket::Family::INET, Socket::Type::STREAM, Socket::Protocol::TCP)
  socket.close_on_exec?.should be_true
end

[ysbaddaden]

I disabled the spec for windows. This is an UNIX only consideration.

[straight-shoota]

We still need to take a look at the Windows stuff. I've created #14636 to track that.