Fix: Don't allocate in Fiber.unsafe_each and Thread.unsafe_each
#14635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods are called during GC collections, which may happen before the Thread::LinkedList objects are created, leading to an infinite loop of malloc -> collect -> malloc -> collect -> ... Kudos to @BlobCodes for identifying the issue! fixes crystal-lang#14633
straight-shoota
approved these changes
May 28, 2024
straight-shoota
changed the title
Fiber.unsafe_each and Thread.unsafe_each
straight-shoota
changed the title
Fiber.unsafe_each and Thread.unsafe_eachFiber.unsafe_each and Thread.unsafe_each
|
I'd suggest adding a note at the callsites re: the reasoning behind this. |
|
@Sija I went to write a note, but then it occurred to me that if the object doesn't exist then there's nothing to iterate in the first place. |
|
True, yet the future me would like to know that these methods shouldn't allocate anything. |
|
Darn, I hoped this would solve also bcardiff/crystal-fswatch#5 but it does not seem the case. |
straight-shoota
pushed a commit
that referenced
this pull request
May 29, 2024
ysbaddaden
deleted the
fix/dont-lazily-initialize-thread-abnd-fiber-linked-list-on-iteration
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods are called during GC collections, which may happen before the Thread::LinkedList objects are created, leading to an infinite loop of malloc -> collect -> malloc -> collect -> ...
Kudos to @BlobCodes for identifying the issue!
fixes #14633