Make JSON.parse return JSON::Any, and make it easy to traverse a dynamic JSON structure. Fixes #1832
#1883
Conversation
| end | ||
|
|
||
| it "gets array" do | ||
| JSON.parse(%([1, 2, 3])).as_a.should eq([1, 2, 3]) |
There was a problem hiding this comment.
What will be the type in this case? Array(JSON::Any) ?
There was a problem hiding this comment.
Or is it Array(JSON::Type) ?
Source says just @raw as Array, so I am not exactly sure what it will do. Probably latter, isn't it?
There was a problem hiding this comment.
Array(JSON::Type). I think as_a maybe won't be useful, right? You'd traverse it with #[]... Or we can make as_a to map the internal values to JSON::Any but that's a separate array -> more memory allocated
There was a problem hiding this comment.
Oh I see.
For sure not in a scope of this PR: Could it be possible to make a thin wrapper JSON::AnyArray, that will wrap Array(JSON::Type) and will provide neat interface, like #[], #[]?, #each that will on the fly re-wrap values of type JSON::Type in JSON::Any ?
There was a problem hiding this comment.
The same suggestion goes about #as_h.
If you like this idea, I can spike it after this PR gets merged.
There was a problem hiding this comment.
@waterlink We could do it, but I don't think it's necessary. JSON::Any already lets you traverse the structure as an array or hash, so I don't know what JSON::AnyArray would add. We can wait until we have a use case.
There was a problem hiding this comment.
Oh, and I added return types so it's clear what is being returned :-)
|
👍 |
…dynamic JSON structure. Fixes #1832
|
Awesome work 👍 |
Make `JSON.parse` return `JSON::Any`, and make it easy to traverse a dynamic JSON structure. Fixes #1832
This is the implementation for #1832
I decided to name the "cast" methods
as_i,as_s, etc., to avoid confusion: if you doto_son a value that isn't necessarily a String, will the value be converted to a String? Or if you doto_iand the underlying value is a String that can be parsed as an int, will it work? Becauseas_...is not related toto_...methods, which usually perform conversion/parsing, the distinction is a bit more clear.