Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IDNA support and integrate with DNS lookup #2543

Merged
merged 13 commits into from Apr 10, 2018
Merged

Add IDNA support and integrate with DNS lookup #2543

merged 13 commits into from Apr 10, 2018

Commits on Mar 4, 2018

  1. Add punycode support and integrate with DNS lookup

    @makenowjust
    makenowjust committed Mar 4, 2018
    Copy the full SHA
    d8073f9 View commit details
    Browse the repository at this point in the history

  2. Add punycode support and integrate with DNS lookup

    @makenowjust
    makenowjust committed Mar 4, 2018
    Copy the full SHA
    e7a17cb View commit details
    Browse the repository at this point in the history

  3. Add top level documentation

    @epergo @makenowjust
    epergo authored and makenowjust committed Mar 4, 2018
    Copy the full SHA
    473ff65 View commit details
    Browse the repository at this point in the history

  4. Remove custom Exception class and use ArgumentError/Exception

    @epergo @makenowjust
    epergo authored and makenowjust committed Mar 4, 2018
    Copy the full SHA
    96ca486 View commit details
    Browse the repository at this point in the history

  5. Refactor complex ternary operator into if/else 

    Changed condition:
`'A' <= c && c <= 'z'`

Into:
`'A' <= c && c <= 'Z'`
    @epergo @makenowjust
    epergo authored and makenowjust committed Mar 4, 2018
    Copy the full SHA
    64a7fda View commit details
    Browse the repository at this point in the history

  6. Move punycode to uri namespace

    @epergo @makenowjust
    epergo authored and makenowjust committed Mar 4, 2018
    Copy the full SHA
    86ac0d7 View commit details
    Browse the repository at this point in the history

  7. Remove char array version encode method 

    And it uses `each_char` instaed of `chars`, it is memory efficient.
    @makenowjust
    makenowjust committed Mar 4, 2018
    Copy the full SHA
    19ab143 View commit details
    Browse the repository at this point in the history

  8. Replace split('.').each do to split('.') do

    @makenowjust
    makenowjust committed Mar 4, 2018
    Copy the full SHA
    52dcf74 View commit details
    Browse the repository at this point in the history

  9. Refactor complex if/else into case

    @makenowjust
    makenowjust committed Mar 4, 2018
    Copy the full SHA
    2c03615 View commit details
    Browse the repository at this point in the history

  10. Mark constants as 'private'

    @makenowjust
    makenowjust committed Mar 4, 2018
    Copy the full SHA
    856b094 View commit details
    Browse the repository at this point in the history

  11. Use string.each_char with block instead of iterator

    @makenowjust
    makenowjust committed Mar 4, 2018
    Copy the full SHA
    66c3b7d View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2018

  1. Refactor using rpartition instead of rsplit

    @makenowjust
    makenowjust committed Mar 6, 2018
    Copy the full SHA
    3864216 View commit details
    Browse the repository at this point in the history

  2. Refactor about variable 'h'

    @makenowjust
    makenowjust committed Mar 6, 2018
    Copy the full SHA
    8ed0777 View commit details
    Browse the repository at this point in the history